Allow a custom buffer to be set

veliovgroup / jazeee-meteor-spiderable

Fork of Meteor Spiderable with longer timeout, caching, better server handling

https://atmospherejs.com/jazeee/spiderable-longer-timeout

33 stars 9 forks source link

Allow a custom buffer to be set #48

Closed nabilfreeman closed 7 years ago

nabilfreeman commented 7 years ago

I'm struggling a lot with PhantomJS due to a select: Invalid argument error (reported 2 years ago and never fixed by the Phantom team) and the advice on getting around this on other web projects is to switch to a newer emulator, like NightmareJS or Electron (which Nightmare is based on).

I'm about to attempt it on a fork of this project, but wondering first what your thoughts are.

nabilfreeman commented 7 years ago

I digged a bit and my issue was actually related to the buffer size being too small... So I made it an optional setting (along with request timeout) & opened a pull request.

I think it makes sense to have these options configurable.