search

veliovgroup / ostrio-Neo4jreactivity

Meteor.js Neo4j database reactivity layer
https://atmospherejs.com/ostrio/neo4jreactivity
BSD 3-Clause "New" or "Revised" License
51 stars 5 forks source link

Two nodes with same _id value will crash server #41

Open Neobii opened 9 years ago

Neobii commented 9 years ago

If you have two nodes with the same _id ie Create (a:person {_id:"100"}) Create (b:person {_id:"100"}) it will cause a continual crash meteor until one of the nodes are deleted.

dr-dimitru commented 9 years ago

@Neobii Why you need two nodes with equal _id? This is only property needs to be unique.

Neobii commented 9 years ago

I would never do it on purpose, but I've ran into issues where it writes to the database twice and neo4j will allow two nodes with the same _id but mongo won't so I think it would be nice to safeguard against it.

On Tue, May 12, 2015 at 4:30 PM, dr.dimitru notifications@github.com wrote:

@Neobii https://github.com/Neobii Why you need two nodes with equal _id? This is only property needs to be unique.

— Reply to this email directly or view it on GitHub https://github.com/VeliovGroup/ostrio-Neo4jreactivity/issues/41#issuecomment-101427589 .

dr-dimitru commented 9 years ago

@Neobii Okay, this happens only when you're using subscibe with node linking (third parameter). That means everything working until data from neo4j translates into minimongo representation. Any ideas how to notify user about this? I can add a note to docs...

Neobii commented 9 years ago

I'm not sure, but while I try to integrate this package into my project, I was going to note some places where it would be nice to have some more robust error reporting, for example when someone tries to query the database with an undefined value.

On Tue, May 12, 2015 at 4:43 PM, dr.dimitru notifications@github.com wrote:

@Neobii https://github.com/Neobii Okay, this happens only when you're using subscibe with node linking (third parameter). That means everything working until data from neo4j translates into minimongo representation. Any ideas how to notify user about this? I can add a note to docs...

— Reply to this email directly or view it on GitHub https://github.com/VeliovGroup/ostrio-Neo4jreactivity/issues/41#issuecomment-101430227 .

dr-dimitru commented 9 years ago

@Neobii But it depends from how you use it. Direct Cypher queries into Neo4j - will return Neo4j error.

Neobii commented 9 years ago

Can you start a gitter for this? I'm going to be working pretty closely with this package so I can ask questions and help with development and github issues doesn't feel like the best place for it.

On Tue, May 12, 2015 at 5:08 PM, dr.dimitru notifications@github.com wrote:

@Neobii https://github.com/Neobii But it depends from how you use it. Direct Cypher queries into Neo4j - will return Neo4j error.

— Reply to this email directly or view it on GitHub https://github.com/VeliovGroup/ostrio-Neo4jreactivity/issues/41#issuecomment-101437209 .

dr-dimitru commented 9 years ago

gitter