veliovgroup / ostrio-Neo4jreactivity

Meteor.js Neo4j database reactivity layer
https://atmospherejs.com/ostrio/neo4jreactivity
BSD 3-Clause "New" or "Revised" License
51 stars 5 forks source link

es6 multiline string query error #66

Closed akaiworld closed 6 years ago

akaiworld commented 8 years ago

I am new to using es6 features. But this seems to be a strange behaviour.

When i use multiline query:

return `
   MATCH (node:Dialog) 
   RETURN node
`;

I do not get results, like when i do like this:

return 'MATCH (node:Dialog) RETURN node';

dr-dimitru commented 8 years ago

idk about ES6 (don't have a chance to test it with this lib), but I guess on compilation with Babel it adds a caret (new line) at the EOL, which is not supported in Cypher.

dr-dimitru commented 8 years ago

Btw now it's better to use neo4jdriver package, it's has more features, and well-tested, and will be updated soon.

This package will be updated later, and currently has lots of lacks.

akaiworld commented 8 years ago

I would like to use neo4jdriver package, but it is not reactive. Do i understand it right?

dr-dimitru commented 8 years ago

Yes, it is not reactive on the client. But neo4jdriver can be reactive on the server

To make neo4jdriver reactive on the client check out meteor-any-db package

And API of this package might change a lot in new version.

akaiworld commented 8 years ago

Nice, i will check this, thanks! Is the one with -fibers postfix also server-reactive? On my machine the one with -fibers postfix worked, not the original one.

dr-dimitru commented 8 years ago

-fibers and fiberless versions has same codebase, just different NPM dependencies.

BTW with Meteor > 1.3, you can use NPM package directly (see neo4j-fiber):

meteor npm install neo4j-fiber

And require it as a module:

Neo4jDB = require('neo4j-fiber');
akaiworld commented 8 years ago

BTW in neo4j-fiber multiline queries work fine.

dr-dimitru commented 8 years ago

Yes, in neo4j-fiber queries goes thru clean up, to make sure it's valid

dr-dimitru commented 8 years ago

@akaiworld thank you for testing with ES6

dr-dimitru commented 6 years ago

Closed due to silence at issue owner end. Feel free to reopen it in case if the issue still persists on your end.

//cc @mksh-su