search

velipso / sndfilter

Algorithms for sound filters, like reverb, dynamic range compression, lowpass, highpass, notch, etc
BSD Zero Clause License
445 stars 70 forks source link

License issue? #7

Open riccardobl opened 6 years ago

riccardobl commented 6 years ago

Hello, first of all, nice work. :squirrel: I'm working on an opensource code that will be released under a permissive license and i have add some reverberation to an audio source, your reverb implementation is exactly what im looking for, but i've read the readme and it says

The reverb effect is a complete rewrite of Freeverb3's Progenitor2 algorithm.

afaik Freeverb3 is a gnu library under gnu gpl license, due to the properties of this license, shouldn't this code be licensed under gpl aswell?

KaneRoot commented 6 years ago

Maybe is there a way to isolate the GPL license to this file only. I just discovered this project yesterday and it's awesome, hope to integrate it in my projects some day, don't want it to be GPL'd.

velipso commented 6 years ago

I don't believe it falls under GPL, because it is a rewrite from scratch. I.e., no copy/pasted code, and if you actually look at Freeverb vs sndfilter code, you can tell it is completely different. The algorithm is the same (or, should be), but the implementation is completely different.

This is no different than Linux being a rewrite of Unix, imo.

Of course, I'm not a lawyer. But I can tell you that I spent a lot of effort reading the Freeverb codebase, figuring out the algorithm behind it, and reimplementing it. Like I said, just compare the source files, it's very obvious.

riccardobl commented 6 years ago

Thanks for the reply. It seems to me that this may fall into a grey area :thinking: , since gpl covers derivate work, and this may be seen as a derivate work, or at least that's how the last part in the readme may be interpreted, but I'm not a lawyer either.

weepy commented 5 years ago

generally it's not possible to license an algorithm