velitasali / gtktitlebar

GNOME extension that removes title bar for non-GTK software (when maximized)
https://extensions.gnome.org/extension/1732/gtk-title-bar/
GNU General Public License v3.0
184 stars 16 forks source link

Titlebar doesn't hide on apps with native Wayland rendering #25

Open icher opened 3 years ago

icher commented 3 years ago

Extension working as expected on apps using Xwayland. Some apps using native Wayland rendering, and extension doesn't work: window is maximized and titlebar still showing. Gtk and Qt apps affected.

Test apps for Fedora (other distros might have different combinations)

Wayland GTK: transmission -- doesn't work. Xwayland GTK: gimp, audacity -- working as expected.

Wayland Qt: qbittorrent, KeePassXC -- doesn't work. Xwayland Qt: Virtualbox, VLC, Kdenlive -- working as expected.

You can check if app using native Wayland or XWayland with xeyes (xorg-x11-apps): the eyes will move if the cursor is over an X or XWayland window.

Fedora 33 Gnome 3.38.5 Wayland

velitasali commented 3 years ago

I have just tested NeoVim-Qt to reproduce your issue and it is hiding the title bar. Could you explain what you mean by "doesn't work"?

By the way, the newer version is intended for GNOME 40 even though it will work on older releases (such as 3.38).

icher commented 3 years ago

Could you explain what you mean by "doesn't work"?

It's simple: neovim-qt is maximized and titlebar is still here (same for qBittorrent and KeePassXC).

Screenshot_2021-03-30_14-26-35_24

Screenshot_2021-03-30_14-36-22_33

I have just tested NeoVim-Qt to reproduce your issue and it is hiding the title bar.

Well, it's strange. Wayland session? Can you please test qBittorrent also?

By the way, the newer version is intended for GNOME 40 even though it will work on older releases (such as 3.38).

Yeah, it doesn't work on previous versions either. I just finally decided to make a bug report.

velitasali commented 3 years ago

Well, it's strange. Wayland session? Can you please test qBittorrent also?

Yeah, I am on Wayland. Just tested qbittorrent as well and it works on that too. Do you have any other extension that would conflict with this one?

Screenshot from 2021-03-30 13-12-17

icher commented 3 years ago

Ok, it doesn't work for apps with native Wayland rendering, only if app running under Xwayland.

velitasali commented 3 years ago

Hm. Are you running these on native wayland?

icher commented 3 years ago

Hm. Are you running these on native wayland?

Yes. Some of these apps using Xwayland and extension working as expected. Some of apps using native Wayland rendering, and extension doesn't work. I thought it works for both, sorry.

velitasali commented 3 years ago

It should be working. Let me see what is going wrong there.

stutzzzz commented 3 years ago

The libreoffice applications also don't hide the tittle bar.

MalcolmMielle commented 3 years ago

It does't work with QTikz but it works fine with terminator and the like on my machine. Hope that it helps narrow it down

bendavis78 commented 3 years ago

I just upgraded to Gnome 40 and switched to a wayland session. The gnome-terminal title bar is no longer hidden for me when maximized.

terlar commented 3 years ago

More applications to add to the list, the terminal emulator kitty as well as foot doesn't hide the title bar Screenshot from 2021-06-17 13-06-00

beanaroo commented 2 years ago

Additionally, Firefox when run with MOZ_ENABLE_WAYLAND=1

velitasali commented 2 years ago

xprop (the program this extension uses to alter window properties) doesn't support Wayland windows. I am not sure if there is any other way to alter those values for Wayland.

geodro commented 2 years ago

More applications to add to the list, the terminal emulator kitty as well as foot doesn't hide the title bar Screenshot from 2021-06-17 13-06-00

Are you using a tiling manager? I think this works only with gnome tiling.

ComplexPlane commented 1 year ago

Wayland programs (wayland "clients") render their own titlebars instead of getting them from the window manager, so it's not possible to hide them right? Probably should write off Wayland support in general.