velo / maven-annotation-plugin

Automatically exported from code.google.com/p/maven-annotation-plugin
0 stars 0 forks source link

plugin should respect classpath / dependency order #31

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
In the newest version (after Dec. 2010) of the plugin the classpath order is no 
longer respected. It's a regression that happened when switching from 1.3.7 to 
2.0.0/2

From the first look at the source code, I see that Set<String> is used in 
MainAnnotationProcessorMojo's getClasspathElements method now to store the 
classpath of the annotation processor (instead of a List like before). This way 
however, the order of the classpath element is lost. Our project requires that 
order to remain unchanged.

I see that this change has happened 
http://code.google.com/p/maven-annotation-plugin/issues/detail?id=26 . Our 
problem is also JPA2 related. We use eclipselink's canocial model generator and 
it needs to have an actual javax.persistence implementation on the classpath, 
so I have put an eclipselinks's implementation before the dependency for the 
(implementation free) javax:javaee-api 6.0 artifact. With 
maven-annotation-plugin 2.0+ however the javaee-api 6.0 jar file always appears 
before the eclipselink persistence api implementation when the processor is 
executed and it thus fails.

Original issue reported on code.google.com by frederic...@googlemail.com on 3 Jul 2011 at 5:03

GoogleCodeExporter commented 9 years ago
Hi, 

you right ..... 

i'll fix it now 

Original comment by bartolom...@gmail.com on 4 Jul 2011 at 7:45

GoogleCodeExporter commented 9 years ago
i've deployed a fix (using LinkedHashSet) in release 2.0.3-SNAPSHOT

test it and give me feedback ... so i can make a new release

thx

Original comment by bartolom...@gmail.com on 4 Jul 2011 at 7:56

GoogleCodeExporter commented 9 years ago
Yes this fixes the problem for me.

Thanks for the quick fix.

Original comment by frederic...@googlemail.com on 5 Jul 2011 at 9:12

GoogleCodeExporter commented 9 years ago
good ... i'll arrange a release soon

thx 

Original comment by bartolom...@gmail.com on 5 Jul 2011 at 10:26