search

velocitylabs-org / turtle

https://app.turtle.cool
MIT License
3 stars 2 forks source link

feat: turtle 404 error page #84

Closed Victor-Salomon closed 1 month ago

Victor-Salomon commented 1 month ago

Turtle Error page

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
turtle-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 3:20pm
turtle-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 3:20pm
Victor-Salomon commented 1 month ago
image

@noahjoeris, I read again the doc. And as far as I understand it and after my tests this morning to trigger it we need both right ?

(To trigger the page I did throw new Error('failed') in the page.tsx and it was not catched so I replace global-error.tsx by error.tsx

But I think we should have both?

noahjoeris commented 1 month ago

From my understanding the global-error should catch everything. But if you tested it feel free to add both.

NunoAlexandre commented 1 month ago

@Victor-Salomon the 404 page doesn't look right to me in the preview 👀

Screenshot 2024-08-12 at 09 00 36
Victor-Salomon commented 1 month ago

@NunoAlexandre wired, let me check again.

As it was more looking like this to me:

Capture d’écran 2024-08-09 à 12 00 19
NunoAlexandre commented 1 month ago

Did you forget to push some changes? Because the content and the text is different.

Victor-Salomon commented 1 month ago

I'm checking.. and testing it more.

But I just replace the global-error.tsx by error.tsx and updated the content.

Lemme ping you once it looks right again.

NunoAlexandre commented 1 month ago

I'm checking.. and testing it more.

But I just replace the global-error.tsx by error.tsx and updated the content.

Lemme ping you once it looks right again.

Merci bien Victor 🤟