search

veloek / tevling

Bring it on
GNU General Public License v3.0
2 stars 1 forks source link

Design updates, winner lottery and dashboard #19

Closed serverlat closed 6 months ago

serverlat commented 6 months ago
veloek commented 6 months ago

I saw quite a bit of refactoring in the last commit, was it based on suggestions from VS Code or Rider? Most of it is fine, but not sure I agree with everything 😅 We'll just keep the changes for now though and perhaps I'll do some cleanup later on. Nevertheless, great work 👍

serverlat commented 6 months ago

It was based on Rider, and I kept it after the cleanup (formatting included) because I liked it, but obviously that's just my subjective judgement and you can totally change it back later on. Let me know if there's anything you disagree with in particular, so I can revert it.

veloek commented 6 months ago

It was based on Rider, and I kept it after the cleanup (formatting included) because I liked it, but obviously that's just my subjective judgement and you can totally change it back later on. Let me know if there's anything you disagree with in particular, so I can revert it.

Code style is always subjective and I really appreciate the effort! It wasn't much I would change, but one example would be to keep named parameters to some of the methods where it's hard to understand what they mean. But it's all minor stuff, let's merge it in 👍 Once it's in main it should automatically be deployed to tevling.com after about a minute or two 🙂