velopack / velopack

Installer and automatic update framework for cross-platform desktop applications
https://velopack.io
MIT License
357 stars 26 forks source link

Error uploading to HTTP S3 endpoints #148

Open caesay opened 4 days ago

caesay commented 4 days ago

If trying to upload to an HTTP endpoint, you get the following error:

When DisablePayloadSigning is true, the request must be sent over HTTPS., retrying in 1 second.

Presumably we actually do want payload signing to be on by default. So we're going to need to make disabling it optional with a CLI arg.

caesay commented 3 days ago

Further issues were:

When DisablePayloadSigning is true, the request must be sent over HTTPS., retrying in 1 second. <-- not sure what this error message means. We have an internal s3 that's exposed over http. does it mean I have to sign the package before I upload it if I want to not use https? I do have to look into signing too, so I guess I'll do that first...

because using Minio with HTTP only

The SSL connection could not be established, see inner exception., retrying in 1 second. is there a way to see the inner exception? [13:51:19 FTL] The SSL connection could not be established, see inner exception. HttpRequestException: The SSL connection could not be established, see inner exception. AuthenticationException: The remote certificate is invalid according to the validation procedure: RemoteCertificateNameMismatch

Because SSL turned on but not trusted? Probably also this: image

May need to support the bucket path syntax instead of DNS prefix