veloren / Airshipper

The official Veloren launcher! This repository is a mirror. Please submit all PRs and issues on our GitLab page: https://gitlab.com/veloren/airshipper
https://veloren.net/download
GNU General Public License v3.0
258 stars 33 forks source link

Changing login name prevents Airshipper from working #138

Open bronson opened 3 years ago

bronson commented 3 years ago

Describe the bug

After I changed my login name, Airshipper could no longer download and run Veloren.

To Reproduce Steps to reproduce the behavior:

  1. log in as root
  2. mv /home/oldname /home/newname
  3. chown -r newname /home/newname
  4. finally, update your home directory in /etc/passwd

Expected behavior

I'd expect Airshipper to continue to work, or at least complain about being unable to find the download destination directory. Instead, when I try to update, it says only, Error occurred. Give it a retry.

Desktop (please complete the following information):

Additional context It's due to the absolute paths stored in these .ron files:

When I update them, Airshipper works normally again.

Quickly glancing through other apps storing data in ~/Library/Application Support, VS Code uses two conventions: ~/path and %APP_SETTINGS_HOME%/path. The other apps seem to avoid storing absolute paths in their application support and preferences files at all.

Songtronix commented 3 years ago

Hopefully fixed by #158 to be included in the 0.4.3 release.