veltman / csvgeocode

Node module for bulk geocoding addresses in a CSV.
164 stars 26 forks source link

an apostrophe can modify results #18

Open Fil opened 6 years ago

Fil commented 6 years ago

I was looking to geocode a file that contained "Villeneuve d'Ascq, France", and the script found "Strada Villeneuve D' Asq, Gorj, Romania".

For some reason the apostrophe was encoded to an HTML numeric entity and caused this problem and the death of many squirrels 🐿.

I fixed it for this specific case with

url = url.replace(/'/, " ");

but maybe mustache has an option for removing html codes or transcoding them properly to utf8.

I can send a PR if you like, but I'm not sure of he scope of the problem or the best way to fix it.

veltman commented 6 years ago

Thanks for the report! I probably won't get to it for a while but I'll definitely take a look.

fthues commented 4 years ago

Same here, apostrophe breaks the request:


Cho d'Punt 34",081 850 02 56,...,
REQUEST_DENIED: You must use an API key to authenticate each request to Google Maps Platform APIs. For additional information, please refer to http://g.co/dev/maps-no-account```
cascafico commented 4 years ago

I confirm: no way to have it geocoded when place contains an apostrophe. I'm using with Nominatim url , osm handler. Verbose echoes "ERROR PARSING RESPONSE: <!DOCTYPE html> and a long html from Nominatim

8 out of 330 rows are not geocoded: these places have an apostrophe in common.