search

veltman / flubber

Tools for smoother shape animations.
MIT License
6.61k stars 167 forks source link

return toShape at the very end of flubber.combine #2

Closed kforeman closed 7 years ago

kforeman commented 7 years ago

If you don't do this, you're not guaranteed to get the correct toShape at the very end of flubber.combine. Simply copied & reversed the method from flubber.separate.

veltman commented 7 years ago

I'm realizing the way this is currently done in separate() isn't consistent with interpolate() and it probably should be, lemme think on this a bit.

veltman commented 7 years ago

I reworked this a bit more in 6e10b4b so that all the logic is still in separate() and it returns original path strings on both ends of the interpolator if appropriate. Seems to work with your example, let me know if you have any issues with it though. Thanks for catching that!

kforeman commented 7 years ago

Works in my testing -thanks!