search

veltzer / openbook

OpenBook is an open source Jazz real book
https://veltzer.github.io/openbook/
GNU General Public License v3.0
275 stars 41 forks source link

Does not work from ZIP download #104

Closed yam655 closed 4 years ago

yam655 commented 4 years ago

The make file defaults to using git calls and find calls to get the filenames.

Please consider using $(wildcard) instead. You don't need to fork an external process. (It's a GNU extension, but you're already using ${filter} and ${subst}, so you're already using GNU extensions.)

Right now, you need to check for the .git directory before trying to run the git ls and git grep commands. Since this isn't done, it just totally breaks if you download the ZIP instead of cloning it.

veltzer commented 4 years ago

Will fix.

veltzer commented 4 years ago

Git is not longer a prereq for building.