search

veltzer / openbook

OpenBook is an open source Jazz real book
https://veltzer.github.io/openbook/
GNU General Public License v3.0
275 stars 41 forks source link

A GitHub Action to build the book #106

Closed skuzzymiglet closed 4 years ago

skuzzymiglet commented 4 years ago

It's based on the README - it fails but I think it would be a good tool to keep stuff working

veltzer commented 4 years ago

I like this idea a lot.

skuzzymiglet commented 4 years ago

Could you look at the log to fix the error? Because the version in Ubuntu 18.04 is the one in the README: https://packages.ubuntu.com/bionic/lilypond

skuzzymiglet commented 4 years ago

Hey there, will this PR be merged, or does it need fixing? I think keeping the build in check is important, even if it fails.

Another possibility is using artifacts to publish the resulting PDFs on each push (that is, once it succeeds)

veltzer commented 4 years ago

It's integrated and I made it work. Thank you for your efforts. They are appreciated. The artifacts are part of the repo and I use the in the github.io page for the project.

veltzer commented 4 years ago

I don't know if you noticed but now the book is building on a matrix of 6 different systems (two ubuntus x 3 python versions). And I have a badge of building on the front README.md. This is all thanks to you. Thank you again.

skuzzymiglet commented 4 years ago

You're welcome! GitHub Actions is so flexible. The ideal automation platform in my opinion. Why is there build_cont?

On 20/05/06 01:29pm, Mark Veltzer wrote:

I don't know if you noticed but now the book is building on a matrix of 6 different systems (two ubuntus x 3 python versions). And I have a badge of building on the front README.md. This is all thanks to you. Thank you again.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/veltzer/openbook/pull/106#issuecomment-624873472

veltzer commented 4 years ago

build builds on ubuntu released and various versions of python. build_cont builds on containers including 20.04 which is still not supported as os by github. Just to cover all bases.