veltzer / openbook

OpenBook is an open source Jazz real book
https://veltzer.github.io/openbook/
GNU General Public License v3.0
276 stars 41 forks source link

Build broken by typesetter feature #20

Closed captbaritone closed 11 years ago

captbaritone commented 11 years ago

Something in commit 1e3b5f83716eed5fd408b975bb5d54c50740c186 broke my build. It was building the jazz book fine, but then I get the following:

$make
doing [out/israelisongbook.ly]
Traceback (most recent call last):
  File "scripts/mako_book.py", line 70, in <module>
    raise e
TypeError: 'Undefined' object does not support item assignment
make: *** [out/israelisongbook.ly] Error 1

I noticed a misspelling in the typesetter lines you added to the Israeli pieces so I corrected these (see pull request) and then the Israeli book built successfully, however then the rock book failed:

$make
doing [out/israelisongbook.ly]
doing [out/israelisongbook.ps]
doing [out/rockbook.ly]
Traceback (most recent call last):
  File "scripts/mako_book.py", line 70, in <module>
    raise e
KeyError: 'typesetter'
make: *** [out/rockbook.ly] Error 1

I assumed that was because the rock numbers don't have typesetter attributes, however I tried adding a typesetter line to aint_no_sunshine.mako and got the following error:

$make
doing [out/rockbook.ly]
Traceback (most recent call last):
  File "scripts/mako_book.py", line 70, in <module>
    raise e
mako.exceptions.SyntaxException: (IndentationError) unexpected indent (<unknown>, line 9) (u"attributes['doGuitar']=True\nattributes['doOwn']=Tr") in file 'src/rock/aint_no_sunshine.mako' at line: 3 char: 1
make: *** [out/rockbook.ly] Error 1
veltzer commented 11 years ago

My bad...

captbaritone commented 11 years ago

Just for book-keeping, it looks to me like this was the commit that fixed this issue: f436edc2ad6dff15f3b85a5f75482ea41c13730a

veltzer commented 11 years ago

Yes It was...:)