search

veltzer / openbook

OpenBook is an open source Jazz real book
https://veltzer.github.io/openbook/
GNU General Public License v3.0
276 stars 41 forks source link

Add "copyright" header in all the pieces #51

Open captbaritone opened 11 years ago

captbaritone commented 11 years ago

From @veltzer's TODO file.

Probably the first step would be to create a test.

captbaritone commented 11 years ago

Just looked, and I think there is already a test for this but it's passing despite the fact that many tunes are missing copyright info.

veltzer commented 11 years ago

If a tune does not have a copyright I complete it by adding a "--- please help me to fill the copyright ---" The idea is to find the right copyright (dig it from books, internet etc...).

captbaritone commented 11 years ago

Maybe we should create a test that checks for that string. It would Be nice to have a way of listing which tunes need work without having to check manually.

Another option might be to empty the string in the song files, and add the "--- please help me to fill the copyright ---" text automatically at render time.

On Wednesday, August 14, 2013, Mark Veltzer wrote:

If a tune does not have a copyright I complete it by adding a "--- please help me to fill the copyright ---" The idea is to find the right copyright (dig it from books, internet etc...).

— Reply to this email directly or view it on GitHubhttps://github.com/veltzer/openbook/issues/51#issuecomment-22685636 .

-Jordan Eldredge

veltzer commented 11 years ago

Agreed.