search

veltzer / openbook

OpenBook is an open source Jazz real book
https://veltzer.github.io/openbook/
GNU General Public License v3.0
276 stars 41 forks source link

Check Jordan's tunes for improper use of \endPart #58

Closed captbaritone closed 11 years ago

captbaritone commented 11 years ago

I misunderstood what this did and used it incorrectly. I will check my tunes and remove instances where it's inappropriate.

veltzer commented 11 years ago

The idea of endPart and startPart is to make the begining and starting of a part of a tune (A, B, C, etc...). What does endPart and startPart mean is completely up to us... So they should be there regardless of their visual effects. If their visual effects do not make sense to you it's better to leave them in the tune and turn their definition to nothing until we find a better solution.

veltzer commented 11 years ago

BTW: same goes for \myEndLine...:)

captbaritone commented 11 years ago

Oh! That was my original interpretation, but when I looked at how they were notated, I assumed I had been wrong. Either way, I'm sure I was inconsistent. I'll check them.

Maybe we could get a note in the docs about how they should be used? Should \startPart come before or after \myMark?

On Thursday, August 15, 2013, Mark Veltzer wrote:

The idea of endPart and startPart is to make the begining and starting of a part of a tube (A, B, C, etc...). What does endPart and startPart mean is completely up to us... So they should be there regardless of their visual effects. If their visual effects do not make sense to you it's better to leave them in the tune and turn their definition to nothing until we find a better solution.

— Reply to this email directly or view it on GitHubhttps://github.com/veltzer/openbook/issues/58#issuecomment-22733813 .

-Jordan Eldredge

veltzer commented 11 years ago

I usually put it after but I haven't really given it much thought...:)

captbaritone commented 11 years ago

The check has been done, and all corrections included in: https://github.com/veltzer/openbook/pull/71