search

veltzer / openbook

OpenBook is an open source Jazz real book
https://veltzer.github.io/openbook/
GNU General Public License v3.0
275 stars 41 forks source link

Add back in double bar at end of song #68

Open captbaritone opened 11 years ago

captbaritone commented 11 years ago

We disabled the double bar at the end of each section because it was breaking repeats at the end of sections, but we also removed the thick double-bar at the end of each song. Was this interfering with repeats at the end of songs?

If no, we should re-enable them because we need a thick double bar at the end of each tune, if yes, what are our other options?

Note: They were removed in commit e0133b465bfc84899672927107359f3b847a68b6

veltzer commented 11 years ago

I removed it for the same reason, they were interfering with repeats.

We need to see if it's possible to have a macro that will put the think double bar ONLY IF there is no repeat. And then bring it back in...

captbaritone commented 11 years ago

Looking into this a little bit and I don't see any clean solutions. For the purpose of brainstorming, here are some possible solutions (each with their own drawbacks):

  1. Don't use wrapper function. Require the typesetter to specify the bars themselves
  2. Create wrapper functions for the possible combinations: \endPartRepeat, \endSongRepeat

I'm not familiar with mako templating. Would there be some way to use mako macros instead of lilypond's and have the behave differently depending on the context?

Let me know if you have any other ideas, or avenues worth looking down.