veluca93 / fpnge

Demo of a fast PNG encoder.
Apache License 2.0
88 stars 8 forks source link

Add fast approximation for predictor search #19

Closed animetosho closed 2 years ago

animetosho commented 2 years ago

From prior discussions: adds FPNGE_APPROX_PREDICTOR switch to enable a fast approximation for predictor search. Benchmarks and effect on compression copied from previous thread:

--- speedup% --- size%
aggregate   +35.79  +0.12
photographic    +36.62  +0.02
synthetic   +35.97  +0.22

This doesn't really eliminate the other possible heuristics for predictor search that were discussed, as it doesn't attempt to skip it.

CLA response: I release these changes to the public domain subject to the CC0 license (https://creativecommons.org/publicdomain/zero/1.0/).

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

veluca93 commented 2 years ago

Mind adding the benchmark/compression results to the PR/commit description?

animetosho commented 2 years ago

Copied results from previous thread into the first post above.