search

veluca93 / fpnge

Demo of a fast PNG encoder.
Apache License 2.0
88 stars 8 forks source link

Fail to compile on GitHub vs, MSVC #28

Closed manticore-projects closed 11 months ago

manticore-projects commented 11 months ago 
 D:\a\fpng-java\fpng-java\fpnge\src\main\cpp\fpnge.cc(816): error C2416: attribute 'msvc::forceinline' cannot be applied in this context

Please refer to: https://github.com/manticore-projects/fpng-java/actions/runs/6925604696/job/18836513239#step:4:106

Can you please help me with this? I have no idea what it means.

veluca93 commented 11 months ago

Interesting... Can you try replacing line 25 (#define FORCE_INLINE_LAMBDA [[msvc::forceinline]]) with (#define FORCE_INLINE_LAMBDA)? That should solve the issue.

On Mon, 20 Nov 2023, 05:45 manticore-projects, @.***> wrote:

D:\a\fpng-java\fpng-java\fpnge\src\main\cpp\fpnge.cc(816): error C2416: attribute 'msvc::forceinline' cannot be applied in this context

Please refer to: https://github.com/manticore-projects/fpng-java/actions/runs/6925604696/job/18836513239#step:4:106

Can you please help me with this? I have no idea what it means.

— Reply to this email directly, view it on GitHub https://github.com/veluca93/fpnge/issues/28, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOPAI7FBIFJCB6FVW6DAFTYFLN5JAVCNFSM6AAAAAA7SJXM4WVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYDCMZVGY3DANQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

manticore-projects commented 11 months ago

Thank you very much, this has worked and FPNGE built on Windows with MVCC. We have a Java Wrapper now with native 64-bit binaries for Linux, Windows and MacOS included: https://github.com/manticore-projects/fpng-java

All published to Maven. Thank you a lot for your help and cheers!