search

vemcogroup / laravel-sparkpost-driver

SparkPost driver to use with Laravel
MIT License
40 stars 16 forks source link

Update options description #10

Closed acurrieclark closed 4 years ago

acurrieclark commented 4 years ago

The options key in the service config array had an additional nested options key, which (after looking at the source) seemed unnecessary. I also added a note clarifying where the config goes.

eldor commented 4 years ago

Hi @acurrieclark,

Actually it is already correct, as the sparkpost api tells is to but all options in a options package: https://developers.sparkpost.com/api/transmissions/#header-request-body

There are some comments here: https://github.com/vemcogroup/laravel-sparkpost-driver/issues/8

Feel free to make a PR for the readme change with the note to clarify where the config goes.

acurrieclark commented 4 years ago

My apologies. I woke up in the night realising I hadn't actually checked the Sparkpost docs before submitting this.

I was trying to add a return_path key to the options and it didn't work in the nested one. I foolishly assumed that it was the whole array which was incorrect rather than the return_path simply belonging in the root array.

I will amend and resubmit.