vemonet / EmojiMart

🏪 Modern emoji picker popup for desktop, based on Emoji Mart, built with Tauri and Svelte
MIT License
65 stars 1 forks source link

🐞 Searches not showing some relevent substrings #13

Open ChildishGiant opened 5 months ago

ChildishGiant commented 5 months ago

Describe the bug

image Searching for imp doesn't show smiling_imp, probably due to imp existing. It does show mending_heart for some reason? 🤔

Reproduction

No response

Operating System

Manjaro 24

Emoji Mart version

0.2.4

Additional context

No response

vemonet commented 2 months ago

Thanks for the notice @ChildishGiant , this is because the search is not done on the emoji :id: but on the main label and some keywords

You can see the exact metadata for all emojis in english here: https://github.com/vemonet/EmojiMart/blob/main/src/data/en.json#L2939

Ideally we should fix the upstream npm package: https://github.com/missive/emoji-mart so that it also use the :id: when doing the search (must be relatively easy)

I have already noted a few improvements that could be done to the search in this other issue: https://github.com/vemonet/EmojiMart/issues/4