search

vemonitor / vedirect_m8

Victron Serial VeDirect Reader and simulator. Fork from karioja/vedirect
MIT License
7 stars 4 forks source link

fix: update serial port regex to support raspberrypi serial devices (/dev/ttyAMA*) #21

Closed amahon closed 2 months ago

amahon commented 2 months ago

Serial ports on many versions of Raspberry PI appear as devices with the prefix /dev/ttyAMA. Some notes can be found here: https://elinux.org/RPi_Serial_Connection

This change updates the regular expression that asserts a correctly formed port to provide compatibility with RPI serial.

I don't see tests that assert the behavior of correct formats, just some tests to assert behavior when a bad port is provided. Thus, not going to make changes to tests - please let me know if I should consider otherwise.

mano8 commented 2 months ago

Thank you! I’ll quickly add tests and incorporate your changes in the upcoming release.