search

vemonitor / vedirect_m8

Victron Serial VeDirect Reader and simulator. Fork from karioja/vedirect
MIT License
7 stars 4 forks source link

Dev #4

Closed mano8 closed 2 years ago

mano8 commented 2 years ago

Improve vedirectsim and serconnect modules. Improve global code style. Update package version to 1.2.7

codecov-commenter commented 2 years ago

Codecov Report

Base: 94.56% // Head: 94.88% // Increases project coverage by +0.31% :tada:

Coverage data is based on head (26f65ba) compared to base (bada934). Patch coverage: 93.91% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4 +/- ## ========================================== + Coverage 94.56% 94.88% +0.31% ========================================== Files 14 14 Lines 1068 1114 +46 ========================================== + Hits 1010 1057 +47 + Misses 58 57 -1 ``` | [Impacted Files](https://codecov.io/gh/mano8/vedirect_m8/pull/4?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eli) | Coverage Δ | | |---|---|---| | [vedirect\_m8/\_\_init\_\_.py](https://codecov.io/gh/mano8/vedirect_m8/pull/4/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eli#diff-dmVkaXJlY3RfbTgvX19pbml0X18ucHk=) | `41.66% <33.33%> (ø)` | | | [vedirect\_m8/serconnect.py](https://codecov.io/gh/mano8/vedirect_m8/pull/4/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eli#diff-dmVkaXJlY3RfbTgvc2VyY29ubmVjdC5weQ==) | `93.93% <90.00%> (-0.26%)` | :arrow_down: | | [vedirect\_m8/vedirectsim.py](https://codecov.io/gh/mano8/vedirect_m8/pull/4/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eli#diff-dmVkaXJlY3RfbTgvdmVkaXJlY3RzaW0ucHk=) | `94.55% <96.77%> (+2.68%)` | :arrow_up: | | [test/test\_serconnect.py](https://codecov.io/gh/mano8/vedirect_m8/pull/4/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eli#diff-dGVzdC90ZXN0X3NlcmNvbm5lY3QucHk=) | `100.00% <100.00%> (ø)` | | | [test/test\_vedirect.py](https://codecov.io/gh/mano8/vedirect_m8/pull/4/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eli#diff-dGVzdC90ZXN0X3ZlZGlyZWN0LnB5) | `100.00% <100.00%> (ø)` | | | [vedirect\_m8/sertest.py](https://codecov.io/gh/mano8/vedirect_m8/pull/4/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eli#diff-dmVkaXJlY3RfbTgvc2VydGVzdC5weQ==) | `94.59% <100.00%> (+0.15%)` | :arrow_up: | | [vedirect\_m8/ve\_controller.py](https://codecov.io/gh/mano8/vedirect_m8/pull/4/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eli#diff-dmVkaXJlY3RfbTgvdmVfY29udHJvbGxlci5weQ==) | `92.42% <100.00%> (ø)` | | | [vedirect\_m8/vedirect.py](https://codecov.io/gh/mano8/vedirect_m8/pull/4/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eli#diff-dmVkaXJlY3RfbTgvdmVkaXJlY3QucHk=) | `93.63% <100.00%> (+0.08%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eli). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Eli)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mano8 commented 2 years ago

Need improve coverage.

mano8 commented 2 years ago

All ok