vemurikarthik / vue-mini-player

A simple mini player powered by petite-vue
MIT License
0 stars 0 forks source link

My feature #50

Closed SiddaniSravani closed 1 year ago

vemurikarthik commented 1 year ago

Here are the GitHub PR diff changes reviewed according to the Coding Standards Document provided:

  1. Naming Conventions:

    • It appears that the variable naming convention has not been adhered to. Particularly, the variable names have been changed to single-letter identifiers in VueMiniPlayerCore/index.ts which are not descriptive (e.g., const WrapperID = "CoreWrapper" to const a = "CoreWrapper" and const app = PetiteVue.createApp to const b = PetiteVue.createApp).
    • Function names have been changed to use hyphen-separated words, which is not standard practice. e.g., PrevSong() to Prev-Song().
    • Constants in functions like get songInfoList() have been renamed to get SONGinfoLIST() which is not in camelCase form.
  2. Code Formatting:

    • The use of curly braces is not consistent. The code songs.forEach((val) => {{} has an additional opening bracket which may lead to an error.
    • There's a misplaced equality operator in this.SongIdList === list which could possibly be a mistake (this should ideally be an assignment statement).
  3. Comments and Documentation:

    • There's a lack of comments documenting changes and explaining the reason behind them. Addition of comments would greatly improve understanding for reviewers and future coders.
  4. Modified and New Files:

The modified files are:

- `src/core/MusicPlayerCore/index.ts`
- `src/core/VueMiniPlayerCore/index.ts`

The newly added files are:

- `src/core/VueMiniPlayerCore/index_2.ts`
- `src/core/VueMiniPlayerCore/new-index.ts` 

Recommendations for Improvements: