Open 0xDTE opened 1 year ago
Based on the provided GitHub PR Diff and the Coding Standards Document, here are the files that do not comply with the coding standards and the recommendations for improvement:
File: src/core/MusicPlayerCore/index.ts
Issue: Inconsistent variable naming. The variable P
is capitalized which is against the camelCase naming convention.
Recommendation: Rename P
to p
.
Issue: The function name Prev-Song
uses a hyphen which is not a standard practice in naming functions.
Recommendation: Rename Prev-Song
to prevSong
or PrevSong
depending on the adopted case style.
Issue: The line this.SongIdList === list
seems to be a comparison operation instead of an assignment. If it's meant to be an assignment, it's a syntax error.
Recommendation: If it's meant to be an assignment, change ===
to =
to assign list
to this.SongIdList
.
File: src/core/VueMiniPlayerCore/index.ts
Issue: The variable a
is a single-letter variable name which is against the coding standards.
Recommendation: Rename a
to a more descriptive name.
Issue: The variable b
is a single-letter variable name which is against the coding standards.
Recommendation: Rename b
to a more descriptive name.
Issue: The function name SONGinfoLIST
is not in camelCase or snake_case.
Recommendation: Rename SONGinfoLIST
to songInfoList
.
Issue: The variable j
is a single-letter variable name which is against the coding standards.
Recommendation: Rename j
to a more descriptive name.
Issue: The line const s = document.getElementById(Wrapper-ID)
seems to be a syntax error as Wrapper-ID
is not a valid identifier.
Recommendation: If Wrapper-ID
is meant to be a string, it should be enclosed in quotes like document.getElementById('Wrapper-ID')
.
Issue: The line p = (e.clientX - s.offsetLeft - slider.client-Width)
seems to be a syntax error as slider.client-Width
is not a valid property access.
Recommendation: If client-Width
is meant to be clientWidth
, it should be written as slider.clientWidth
.
Issue: The line this._UpdateShowPrecentage(p / slider.client-Width)
seems to be a syntax error as slider.client-Width
is not a valid property access.
Recommendation: If client-Width
is meant to be clientWidth
, it should be written as slider.clientWidth
.
File: src/core/VueMiniPlayerCore/index_2.ts
src/core/VueMiniPlayerCore/index.ts
with the same issues.src/core/VueMiniPlayerCore/index.ts
.File: src/core/VueMiniPlayerCore/new-index.ts
src/core/VueMiniPlayerCore/index.ts
with the same issues.src/core/VueMiniPlayerCore/index.ts
.Please note that these are recommendations based on the provided coding standards and the visible parts of the PR. There might be other issues not visible in the provided PR diff.
torvalds.dev is analyzing the pull request