search

venantius / accountant

ClojureScript navigation for single-page applications, made simple.
Eclipse Public License 1.0
250 stars 39 forks source link

window.location.port and goog.uri.getPort defaults are not equivalent. #36

Closed minikomi closed 7 years ago

minikomi commented 7 years ago

In google chrome at least, when no port is specified on a link:

The test for port equality fails when no port is specified for the link, preventing accountant from stepping in.

venantius commented 7 years ago

Open to a PR :D?

minikomi commented 7 years ago

Sure, I can do that, but I'd like to get @nicorikken in too -- I can't get 1.8.0 to work with or without port in any browser since window.location.port is always a string and goog.Uri.getPort is always a number.

venantius commented 7 years ago

Resolved by #38. Will release this evening. If I forget feel free to remind me.