Consider using `goog.url` instead of `goog.Uri`

venantius / accountant

ClojureScript navigation for single-page applications, made simple.

Eclipse Public License 1.0

250 stars 39 forks source link

Consider using `goog.url` instead of `goog.Uri` #67

Open p-himik opened 4 years ago

p-himik commented 4 years ago

goog.Uri does not decode values correctly and here https://github.com/google/closure-library/issues/1083#issuecomment-700305976 it was suggested that it's almost certainly better to just use goog.url.

iku000888 commented 4 years ago

@p-himik

Is this related to https://github.com/venantius/accountant/issues/66 ? Either way happy to review a patch!

p-himik commented 4 years ago

Related but different. At the very least, I have no idea if goog.url works with data URIs.

Either way, I don't think that goog.url can be used any time soon given that it's a recent addition and CLJS still depends on an older Closure library that doesn't have it.