search

venantius / ultra

A Leiningen plugin for a superior development environment
Eclipse Public License 1.0
1.24k stars 35 forks source link

upgrade to nrepl 0.6.0 and whidbey 2.0.0 #101

Closed johannesloetzsch closed 5 years ago

johannesloetzsch commented 5 years ago
venantius commented 5 years ago

I think this may need to be rebased onto master?

johannesloetzsch commented 5 years ago

I think this may need to be rebased onto master?

I merged upgrade-nrepl into master before I did the changes. The branch of the pull request is now 2 commits ahead of master, so I think no rebase is needed.

If you are willing to use this as the new master, feel free to squash the changes.

johannesloetzsch commented 5 years ago

This branch works well with the new released [mvxcvi/whidbey "2.1.0"].

I would appreciate, if you could test it, give feedback and eventually (squash+)merge it.

venantius commented 5 years ago

Hey - I'm sorry for the delay in getting back to you on this.

Thank you for the work you've put in here - I've noticed you also helping out other people upstream. I've been working on this problem in a branch of my own and will be merging that. At the moment I've got everything in a workable state but the perfectionist in me is a little irked about the one remaining change in behavior that I don't love, which is this.

I'm going to push my changes up for now and merge into master, but I'm going to wait a few days to cut a release to see if the newline issue gets resolved before then.

johannesloetzsch commented 5 years ago

ok, thanks :)