venantius / ultra

A Leiningen plugin for a superior development environment
Eclipse Public License 1.0
1.24k stars 35 forks source link

Allow Additional ANSI Color Choices #30

Closed drbobbeaty closed 9 years ago

drbobbeaty commented 9 years ago

I'm really impressed by this plugin... very very nice. I went to define the custom color scheme and realized that Ultra only allows the default 8 ANSI colors even though the way their escape codes are being looked up it's possible to add bold- in front of each.

If I might suggest, maybe in colorscheme.clj on line 15, the code might read:

(#{:black :red :green :yellow :blue :magenta :cyan :white
   :bold-black :bold-red :bold-gree :bold-yellow :bold-blue :bold-magenta :bold-cyan :bold-white} k))

so that for those among us that want to have the complete 16 ANSI colors, we can use them.

The other alternative I thought of was to allow the :bold modifier in the vector for a color descriptor. Something like;

  :boolean [:bold :cyan]

In any case, it's a great plugin, and thanks for listening.

drbobbeaty commented 9 years ago

What a GOOF! It's already there with the second suggestion!

I'm sorry for wasting your time.

venantius commented 9 years ago

No worries, glad you're liking it! :)