search

venantius / ultra

A Leiningen plugin for a superior development environment
Eclipse Public License 1.0
1.24k stars 37 forks source link

Update puget dependency #31

Closed Leonidas-from-XIV closed 9 years ago

Leonidas-from-XIV commented 9 years ago

This version of puget has explicit support for Clojure 1.7 and should not display warnings because of shadowed identifiers from Clojure proper.

venantius commented 9 years ago

Hey, thanks for opening this up - it was literally the next thing on my to-do list. There's a bit more work to be done here as far as updating Puget - you'll notice that there's a bunch of dependency injection that goes on here https://github.com/venantius/ultra/blob/master/src/ultra/plugin.clj#L37; and I'd like to keep the Puget and Whidbey dependencies in sync. Mind updating this to track the latest versions of both of those?

Leonidas-from-XIV commented 9 years ago

Sure thing, I'll send you an updated PR tomorrow!

Leonidas-from-XIV commented 9 years ago

Looks like whidbey's API changed, need to fix this up.

Edit: Done. looks like it was just a simple rename.

venantius commented 9 years ago

Great, I'll take a look at this over the long weekend. Haven't forgotten this :)

venantius commented 9 years ago

LGTM.

Leonidas-from-XIV commented 9 years ago

Thanks!