search

venantius / ultra

A Leiningen plugin for a superior development environment
Eclipse Public License 1.0
1.24k stars 35 forks source link

Ultra throws "= expects more than one argument" while this is allowed #72

Closed FreekPaans closed 6 years ago

FreekPaans commented 7 years ago

When ultra is loaded

(is (= 1))

throws an Exception "= expects more than one argument", but this is actually valid, so I guess it should work in ultra as well?

venantius commented 7 years ago

Sorry, can you elaborate on what you mean by "when ultra is loaded"?

FreekPaans commented 7 years ago

Ah, I mean that ultra is enabled, that is enhancing test output and all. On Fri, 3 Feb 2017 at 17:50, Ursa americanus kermodei < notifications@github.com> wrote:

Sorry, can you elaborate on what you mean by "when ultra is loaded"?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/venantius/ultra/issues/72#issuecomment-277299762, or mute the thread https://github.com/notifications/unsubscribe-auth/ADfb6W5VgEWWduK1OkImppNtzpYS5Kn8ks5rY1rvgaJpZM4L2eYq .

venantius commented 7 years ago

Hm, right you are. I'll have to look into this.

venantius commented 6 years ago

I am going to close this as "won't fix".

While you're correct that Clojure legally permits = to take a single arity, it will always return true. In that context I cannot see a valid reason for doing so within an is testing block.

It's possible that I'm missing something, in which case I'm happy to revisit this. But the current behavior seems reasonable to me, and likely to help people from accidentally writing tests in which they intended to compare two or more objects but failed to align parentheses correctly.