search

venantius / ultra

A Leiningen plugin for a superior development environment
Eclipse Public License 1.0
1.24k stars 35 forks source link

Add test report for :error (addresses #57) #73

Closed Jell closed 7 years ago

Jell commented 7 years ago

the tests are passing, but I am not exactly sure how I would go about writing a test for this

venantius commented 7 years ago

Could you amend your commit to include a message that describes the original problem and the fix? Thanks!

Re: tests...yeah, it's hard. You could try to capture the string output using with-out-str and then compare that against a known stacktrace string. If you don't write tests I won't hold it against you, so long as you've validated that this actually works as expected.

Jell commented 7 years ago

I've updated the commit message. I made a serious attempt at writing some tests for it but I'm afraid I'm failing at this :/

venantius commented 7 years ago

Left a few comments. Sorry on the delay in looking at this :(

Jell commented 7 years ago

I've updated the PR as per your comments! Cheers

venantius commented 7 years ago

Looks great, thanks! Will cut a release later today.