venantius / ultra

A Leiningen plugin for a superior development environment
Eclipse Public License 1.0
1.24k stars 37 forks source link

Check number of arguments to = at read time #77

Closed divergentdave closed 6 years ago

divergentdave commented 7 years ago

This is the same as pjstadig/humane-test-output#21. When ultra has been activated, the overwritten = method on assert-expr triggers nuisance warnings from the eastwood static analysis tool. The warning message is "Test expression is always logicla true or always logical false." This PR fixes the nuisance warnings by checking the number of arguments at read time, rather than at run time.

venantius commented 6 years ago

Seems reasonable.