search

venantius / ultra

A Leiningen plugin for a superior development environment
Eclipse Public License 1.0
1.24k stars 35 forks source link

Update org.clojure/tools.nrepl 0.2.12 to nrepl 0.5.3? #95

Closed rux closed 5 years ago

rux commented 5 years ago

According to https://github.com/clojure/tools.nrepl, the active development of nREPL has moved to https://github.com/nrepl/nrepl earlier in 2018.

cbcoutinho commented 5 years ago

Possibly related technomancy/leiningen#2497 and technomancy/leiningen#2506

bbatsov commented 5 years ago

Yes, the old project is no more. Refer to https://metaredux.com/posts/2018/10/29/nrepl-redux.html for more details. All projects should adopt the new package, as the main tooling already switched to it and tools like CIDER will just drop support for the old package very soon.

That's a simply way of supporting both versions https://github.com/clojure-emacs/cider-nrepl/blob/master/src/cider/nrepl.clj#L11

bbatsov commented 5 years ago

@cbcoutinho Those bugs you refer to (which are the same bug actually) are unrelated to the need for updating the nREPL dep for ultra and similar packages.

venantius commented 5 years ago

We'll need https://github.com/greglook/whidbey/issues/26 to go in first as otherwise Ultra will be on nREPL and our deps will be on clojure.tools.nrepl.

narkisr commented 5 years ago

Is this issue resolved yet?

As far as I can tell it was fixed in whidbey 2.0.0 but older dependency is still used in ultra 0.5.4

Thanks

narkisr commented 5 years ago

Trying to migrate to whidby 2.0.0 results with:

clojure.lang.Compiler$CompilerException: java.lang.RuntimeException: Unable to resolve var: whidbey.repl/printer in this context, compiling:(ultra/colorscheme.clj:62:5)

Looks like this is a breaking change