search

venantius / ultra

A Leiningen plugin for a superior development environment
Eclipse Public License 1.0
1.24k stars 37 forks source link

[ultra] Require nrepl or clojure.tools.nrepl dynamically #96

Open venantius opened 5 years ago

venantius commented 5 years ago

clojure.tools.nrepl is now officially deprecated and has been replaced with nrepl/nrepl. This commit updates all direct references to clojure.tools.nrepl to use a dynamic import that checks to see if clojure.tools.nrepl is on the path and otherwise to use the new nrepl.

As we rely on a significant amount of functionality in Whidbey/Puget, those will also need to have their references updated.

This PR resolves #95

buzzdan commented 5 years ago

@venantius any updates on this issue (#95)? i see greglook/whidbey#26 is already resolved

venantius commented 5 years ago

I'll try to give this a look over the weekend.

elzibubble commented 5 years ago

@venantius Thanks for looking at this, any chance we could get it over the line please?

venantius commented 5 years ago

Leiningen 2.9.0 has introduced some sort of new issue that needs to be resolved upstream again - not totally clear what it is yet. I could try to fix this just for Lein 2.8.3 but I'd rather just fix it for 2.9.0 onwards.

venantius commented 5 years ago

Reference: https://github.com/greglook/whidbey/issues/27