search

vencax / netlify-cms-github-oauth-provider

netlify oauth github client sending token in form as netlify service itself
204 stars 127 forks source link

aws lambda support #16

Closed davidayalas closed 4 years ago

davidayalas commented 5 years ago

Main changes are an IF to detect if is normal NodeJS or AWS Lambda and the npm package to allow that feature. README update too.

vencax commented 5 years ago

Hi, thanks for contrinution. I am not sure whether suggest you to move this pull functionality into separate repo with refactoring the index.js and this repo as a dependency. Or leave it in this even though fraction of users would use it. Anyone else suggestion?

gregorycuellar commented 5 years ago

Hi, thanks for contrinution. I am not sure whether suggest you to move this pull functionality into separate repo with refactoring the index.js and this repo as a dependency. Or leave it in this even though fraction of users would use it. Anyone else suggestion?

Hi,

I suggest to move all except app.listen in a separate file ( ex app.js ) then having 2 separated entry :

And maybe lambda dependency can be marked as optional.

I can provide a PR if needed.

vencax commented 5 years ago

Ok, please do it :) thankyou

Dne st 15. 5. 2019 12:52 uživatel CUELLAR Grégory notifications@github.com napsal:

Hi, thanks for contrinution. I am not sure whether suggest you to move this pull functionality into separate repo with refactoring the index.js and this repo as a dependency. Or leave it in this even though fraction of users would use it. Anyone else suggestion?

Hi,

I suggest to move all except app.listen in a separate file ( ex app.js ) then having 2 separated entry :

-

index.js : for non lambda users => require app.js and then app.listen , it will provide the same behavior as today and users which doesn't use lambda will not be impacted

lambda.js : for lambda users => require app.js + lambda code

And maybe lambda dependency can be marked as optional.

I can provide a PR if needed.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vencax/netlify-cms-github-oauth-provider/pull/16?email_source=notifications&email_token=AAJBETT7XUGAAMDG4OPHMD3PVPTPTA5CNFSM4HHLOPD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVOJCUY#issuecomment-492605779, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJBETUOSSFRBQB3OQSIUZLPVPTPTANCNFSM4HHLOPDQ .