slaren
commented
5 years ago I did some tests regarding overhead of using inner functions and what I found is that while there is some overhead creating and calling an inner function, at least in my computer it is negligible (in the order of 1.5 microsecond slower). However, using instead a call to a member function is even slower.
This is how I tested it, in case you want to test it yourself or you want to verify that my methodology is correct: https://gist.github.com/slaren/bfaa5365eff2c41fd4db1dfef49054fb In my computer, what I get is approx ~ f1: 2us / f2: 0.65us / f3: 3us
In any case, what I take from that is that the difference between the different versions is so small that it is just not worth changing it if doing so makes the code harder to understand. Thus, before changing any code to improve performance, you should at least verify that it will have a measurable impact.
vendethiel
ManneN1
Improved Interrupt Module:
Is more modular, interrupts have priority (doesn't automatically override other auras) and are automatically hidden after duration end (previously required new AURA_UNIT tick to be removed which could leave it there for some time).
Improved Efficiency of ClassIcon Module:
In accordance with Phanx comment in https://www.wowinterface.com/forums/showthread.php?t=51484 I've removed the local function inside ScanAuras() which takes a lot of time to create each time a UNIT_AURA event is received.
Minor GUI Changes: