search

vendethiel / GladiusEx

13 stars 19 forks source link

Bugfixes for alert module triggers #26

Closed OperationXen closed 5 years ago

OperationXen commented 5 years ago

Some of the functions used in the alert module had not been updated to reflect the changes made to the API in 8.0.1 which resulted in the alerts module not working for aura detection or cast detection.

UnitBuff no longer accepts a spell name parameter, this has been replaced with AuraUtils.FindAuraByName

The parameter passed to the event handler for UNIT_SPELLCAST_START now appears to be a spell ID rather than a name, reusing name getter to resolve this to a key name for comparison.

OperationXen commented 5 years ago

Apologies if this is poor practise, I've never written any lua or worked with wow addons before, I just noticed the functionality wasn't as expected and hacked together a fix.

vendethiel commented 5 years ago

Sure, seems good, I’ll try to take a look

vendethiel commented 5 years ago

Sorry for the delay, I've been unsubbed since. I'll try to resub soon-ish and take a look.

OperationXen commented 5 years ago

No problem, I've been idle or doing emissaries while my guild dies so I'm in a similar boat, aiming to come back for 8.2

vendethiel commented 5 years ago

Thanks!