vendethiel / GladiusEx

14 stars 20 forks source link

Expansion/legion #2

Closed vendethiel closed 7 years ago

vendethiel commented 7 years ago

First commit contains my changes Second commit contains the libs.

I really want to ditch .pkgmeta for many reasons, most of which I explained in #1 already. .pkgmeta doesn't help with basically anything – it doesn't provide versioning, it has stale references to everything, and it encourages using a tool that no one uses. If anything I'd rather use git submodules. I also had to patch LibCooldownTracker to add per-spec cooldown overrides like legion has.

vendethiel commented 7 years ago

Ok, got the dashboard

slaren commented 7 years ago

Sure, do whatever you want with the issues. The build failed again: Unknown repository type, or unable to connect to repository. https://repos.wowace.com/wow/libdispellable-1-0

vendethiel commented 7 years ago

Yup, I saw it go through. No issue with reading through CI logs :).

I want to take the time to say "thank you" for your supervision even though you really have no reason to care at all, during this month-and-so.

vendethiel commented 7 years ago

Whoo! Seems like it turned green

vendethiel commented 7 years ago

Aaaand it works!

vendethiel commented 7 years ago

@slaren About to release as 1.0-beta.

slaren commented 7 years ago

Thank you for contributing to the project. It's the least I can do if someone is willing to contribute to my project rather than forking or starting their own.

You can have the packager make a release by creating a tag in the repository. There is some documentation about all this: https://www.curseforge.com/docs/packaging

vendethiel commented 7 years ago

Alright. Pushed a tag! Let's see.

vendethiel commented 7 years ago

Now I just need to figure out how to "push" the beta to mods.curse... Or do betas not get there?

vendethiel commented 7 years ago

Oh, is it because it's "under review"?

slaren commented 7 years ago

I am not sure why it is "under review", I guess some mod has to validate the project again.

vendethiel commented 7 years ago

It went through! 👍