search

vendethiel / GladiusEx

13 stars 19 forks source link

Do talent detection #3

Closed vendethiel closed 6 years ago

vendethiel commented 6 years ago

https://mods.curse.com/addons/wow/libgroupinspect

We might need to manually enter data points (spell id => position in the tree, I mean).

Not sure how to detect PVP talents.

vendethiel commented 6 years ago

I just realized we have it as a dependency already, it's just seemingly unused.

slaren commented 6 years ago

It's used here: https://github.com/slaren/GladiusEx/blob/bb125ef5889780098b202b951f3d38da5e69c275/GladiusEx.lua#L361 https://github.com/slaren/GladiusEx/blob/bb125ef5889780098b202b951f3d38da5e69c275/GladiusEx.lua#L808-L815

vendethiel commented 6 years ago

Oh, alright. Guess I can try to bend LibCooldownTracker to force-detect a spell. I can probably make this more generic:

https://github.com/vendethiel/LibCooldownTracker-10/blob/f703b7d40530f114f918f9d1b08bfc1909b73814/library.lua#L461

I'm just not sure how I should "un-detect" when someone specs out of a spell. Sounds tough.

How do you do these code embeds?

slaren commented 6 years ago

I used the "copy permalink" option in the three dots button and just pasted that link here.

vendethiel commented 6 years ago

Okay, well, I'm not sure how that works.

slaren commented 6 years ago

https://github.com/vendethiel/LibCooldownTracker-10/blob/f703b7d40530f114f918f9d1b08bfc1909b73814/library.lua#L461

I guess it only works for this repository ?

vendethiel commented 6 years ago

Looks like it. Thanks for checking

vendethiel commented 6 years ago

Even though it isn't documented as such on e.g. wow.amepedia, it seems GetPvpTalentInfo can use inspect data

vendethiel commented 6 years ago

will probably have to fork LibGroupInSpecT, since the maintainer seems a bit inactive and there's no repo on GH.

vendethiel commented 6 years ago

From: https://github.com/tomrus88/BlizzardInterfaceCode/blob/c9d5cf53f3165beb2850dfde793d531e4b9dbaec/Interface/AddOns/Blizzard_InspectUI/InspectPVPFrame.lua#L75-L76

It seems that the GetActiveSpecGroup(true) hack I used (as GetActiveTalentGroup) for wotlk addons is still needed..

vendethiel commented 6 years ago

my hacked-on version of LibGroupInSpecT does primitive pvp detection, but the maintainer doesn't seem to check wowace often. Not sure what to do yet, might end up forking the lib...

The basics work tho, talent detection works correctly. I also added LibFunctional to LibCT, just to make it easier to manipulate the data (here, remove the previously-detected talents).