search

vendethiel / GladiusEx

13 stars 19 forks source link

Game is crashing after update #38

Closed web-deved closed 2 years ago

web-deved commented 2 years ago

Hey man,

this is by far my favorite wow addon! Sadly, my game has been crashing when entering the arena for a bit now. I don't know much about LUA but there is a function that recursively calls itself: https://github.com/vendethiel/GladiusEx/blob/30e70a440622ab59c5cc631b82a9d6e52a86e8b3/modules/auras.lua#L183 And since my script is running too long I am assuming that the function never goes inthe any of the other if conditions. Replacing that line with return false removes all my issues. I am not using the "show only dispellable auras" options so I do not know what the impact on that functionality is.

I'll attach the LUA Error:

Message: Interface\AddOns\GladiusEx\modules\auras.lua:177: script ran too long
Time: Wed Aug 25 19:22:12 2021
Count: 15
Stack: Interface\AddOns\GladiusEx\modules\auras.lua:177: script ran too long
[string "=(tail call)"]: ?
[string "@Interface\AddOns\GladiusEx\modules\auras.lua"]:177: in function <Interface\AddOns\GladiusEx\modules\auras.lua:176>
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
...
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "@Interface\AddOns\GladiusEx\modules\auras.lua"]:286: in function `scan'
[string "@Interface\AddOns\GladiusEx\modules\auras.lua"]:505: in function `?'
[string "@Interface\AddOns\Masque\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:119: in function <...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:119>
[string "=[C]"]: ?
[string "@Interface\AddOns\Masque\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:29: in function <...que\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
[string "@Interface\AddOns\Masque\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:64: in function `Fire'
[string "@Interface\AddOns\ElvUI\Libraries\Ace3\AceEvent-3.0\AceEvent-3.0.lua"]:120: in function <...s\ElvUI\Libraries\Ace3\AceEvent-3.0\AceEvent-3.0.lua:119>

Locals: <none>
vendethiel commented 2 years ago

Thanks, that definitely is an error. LibCanDispel is broken and my fix is wrong

vendethiel commented 2 years ago

fixed in 6db10411883e420255791cae6260fb4536aacd30