vendethiel / GladiusEx

13 stars 19 forks source link

Party > Auras > Debuffs > Show only dispellable not working #62

Open abstract-entity opened 1 year ago

abstract-entity commented 1 year ago

Party > Auras > Debuffs > Show only dispellable not working, is not working, it filter all debuffs

When i don't check option, dispellable debuffs appears image

When i check option, dispellable debuffs disapears image

vendethiel commented 1 year ago

I should have a fix in the next version.

pmbednarczyk commented 1 year ago

When can we expect next version @vendethiel ? :)

vendethiel commented 1 year ago

I released 2.6.1, which should fix it.

pmbednarczyk commented 1 year ago

THX, but for me this problem still occurs :( I want to mention that my bug occurs in Arena > Auras > Debuffs > Show only dispellable. (not Party)

Edit: I hacked it locally :D and managed to work for my Resto Shammy: image

It is very ugly solution.... I believe it is not optimised because i removed the first if. And dont look at this dispelType == Curse :D it shouldnt be there

pmbednarczyk commented 1 year ago

it is me again :) I think i found reasons why it didin't work: First: isBuffdoesnt exist, it need to be repalced with buffs variable - which comes from params Second: uppercase "MAGIC" does not work, it has to be "Magic"

At least for me it helped, and I can see dispellable buffs for my Shaman. (works only in Arena, in test mode it doesnt):

local function CanDispel(unit, buffs, dispelType, spellID)
    if (buffs and not UnitCanAttack("player", unit)) or (not buffs and not UnitCanAssist("player", unit))then
        return false
    end
  -- TODO update LibDispellable
  -- TODO handle the *other* evoker dispels
  local hasMonkDispel = IsPlayerSpell(115450)
  local hasEvokerDispel = IsPlayerSpell(360823)
  local hasShamanDispel = IsPlayerSpell(378773)
  local hasDispel = hasMonkDispel or hasEvokerDispel or hasShamanDispel
  if buffs and hasDispel and dispelType == "Magic" then
    return true
  end
  return LD:CanDispel(unit, buffs, dispelType, spellID)
end
vendethiel commented 1 year ago

Ahh, that looks like a typo/copypaste-o. Thanks, I'll try to take a look in the afternoon or tomorrow.

vendethiel commented 1 year ago

Just pushed 2.6.2, will be available on CF/wago approves the new file.