search

vendethiel / Sprockets-PHP

Sprockets for PHP
MIT License
50 stars 4 forks source link

Wrong dependencies #34

Open Nek- opened 10 years ago

Nek- commented 10 years ago

Why are they preprocessor as depedencies ?

I can understand that in order to test you could need some of theme, but it's exacly why require-dev exists.

Also notice that lessphp is not maintained anymore. The test should be use the standard less version using npm to install it.

vendethiel commented 10 years ago

maybe they should even be suggested. But I think at that point, none of them is maintained anymore ...

Nek- commented 10 years ago

Why suggesting things we don't believe in ? ^^

They should be in dev dependencies if you need them for testing (even if it's better to have them as node dependencie for the dev), and that's all.

vendethiel commented 10 years ago

I mean something like "suggest-depend". Can't remember the name atm.

Nek- commented 10 years ago

I understood, yep. My answer is still valid :p .

vendethiel commented 10 years ago

Yeah, though I created this library for people not having access to node stuff (hence why less/coffee are the PHP version), but if there's a really big difference, I should indeed use npm versions (and maybe create a pless, or lessp, of w/e)

Nek- commented 10 years ago

i.e for less: bootstrap is not compabitle with lessphp.