vendethiel / ezarena

Reprise de l'ultimarena pour ajouter plus de fonctionnalités et un RPG !
MIT License
4 stars 3 forks source link

remove clans_mod, add guilds by renlok #59

Closed vendethiel closed 7 years ago

vendethiel commented 7 years ago

Almost done.

I need to integrate the party mod.

https://github.com/vendethiel/ezarena/blob/d8e0e2532a65e9dab73c27e5d873fcb46d9b2a4d/adr_clans.php#L434-L437

vendethiel commented 7 years ago

It seems Renlok's guild mod is just a small extension to Guild Alliances... Whatever. It's installed...

vendethiel commented 7 years ago
vendethiel commented 7 years ago

@winzombie are you sure the version you sent me is the correct one? I've had to patch it left and right.

winzombie commented 7 years ago

@vendethiel idk, long time ago i install it and it working correctly. thet last version i have. u can look at https://sourceforge.net/projects/advanceddungeon/files/phpBB2/ADR%20Addons/

winzombie commented 7 years ago

another mods pack little bigger vs sort https://mega.nz/#!g84zyIiA !-kAzeJHMCqeckHh_6dvvwu_OFsfOnV0mP-jl6m2Crso

vendethiel commented 7 years ago

Some keys are missing and al. i'll try later with a different version. But the installation file is wrong

vendethiel commented 7 years ago

another mods pack little bigger vs sort https://mega.nz/#!g84zyIiA !-kAzeJHMCqeckHh_6dvvwu_OFsfOnV0mP-jl6m2Crso

There's nothing more there...

vendethiel commented 7 years ago

Whatever. I'll do whatever I need to...

winzombie commented 7 years ago

2 1 its working in cgb premod. ill try install it later too

vendethiel commented 7 years ago

Well for example there's nothing in the install.txt that tells you where to put the constants. I can "guess" where they're supposed to be, but that's suboptimal.

vendethiel commented 7 years ago

I don't have CGB's premod btw. Does it have interesting mods we don't?

winzombie commented 7 years ago

https://sourceforge.net/projects/cgbrpg/ its just another premod, withs few mods and fine prosilverse template

vendethiel commented 7 years ago

Okay. I'll download it. Maybe I can extract a few files.

vendethiel commented 7 years ago

Note that EzArena's AD&R is a bit too customized to just add in mod like taht.

vendethiel commented 7 years ago

Fixing bugs left and right. Still some CSS issues to fix...

vendethiel commented 7 years ago

it also does some really really shitty things like DELETING USERGROUPS WHEN THE USER DISBANDS A GUILD

vendethiel commented 7 years ago

also there's no security at all. you can delete anyone's guild. What is this shit mod.

winzombie commented 7 years ago

this mods writed along ago by users who know php on school level etc xD what do u want from it)))) btw i very like mods by lagunacid dnd reborn, but i can't install it never=(

vendethiel commented 7 years ago

The one that adds D&D rules to AD&R? I think it changes the gameplay a bit too much.

winzombie commented 7 years ago

yeap, but imho thats better fighting formula from standart adr.

vendethiel commented 7 years ago

idk. maybe as an option. But it's too much work to integrate it only as an option..

winzombie commented 7 years ago

yeap. its to strong for my knowledge but. seems to be good

vendethiel commented 7 years ago

There are a lot of mods already installed. They'd all need to be adapted.

vendethiel commented 7 years ago

The guild mod is really buggy and really bad. i.e. it uses the character_name as leader in the table... Instead of just querying...

vendethiel commented 7 years ago

Got a lot done. Still got a lot of fixes to do however.

vendethiel commented 7 years ago

Okay. I understand now. The adr_guilds in cgphpbb is NOT the extended version. It's a basic one with no ranks and al.

vendethiel commented 7 years ago

By that, I meant that the one installed is NOT renlok's

vendethiel commented 7 years ago

I'm basically rewriting the mod right now, because renlok just coudn't code.

vendethiel commented 7 years ago

Done rewriting adr_guilds.php. I'll try to do the adr_guilds_leaders.php one soon-ish(™)

winzombie commented 7 years ago

new trouble in leader control panel:

ould not query count for total awaiting approval

DEBUGGAGE

Ошибка SQL: 1054 Unknown column 'character_guild_approval' in 'field list'

Запрос SQL:
SELECT character_guild_approval FROM phpbb_adr_characters WHERE character_guild_approval = 1

Линия: 216
Файл: D:\drou\EasyPHP\www\adr_guilds_leader.php

Ошибка в коде:
Линия-210:   
Линия-211:     // Count characters awaiting approval 
Линия-212:     $sql = " SELECT character_guild_approval FROM " . ADR_CHARACTERS_TABLE . " 
Линия-213:     WHERE character_guild_approval = $guild_id "; 
Линия-214:     if( !($result = $db->sql_query($sql)) ) 
Линия-215:     { 
Линия-216!     message_die(GENERAL_ERROR, 'Could not query count for total awaiting approval', '', __LINE__, __FILE__, $sql); 
Линия-217:     } 
Линия-218:     $total_awaiting = $db->sql_numrows($result); 
Линия-219:   
Линия-220:     $template->assign_vars(array( 
vendethiel commented 7 years ago

vendethiel commented 4 days ago Done rewriting adr_guilds.php. I'll try to do the adr_guilds_leaders.php one soon-ish(™)

I didn't do it yet. I've been busy with work projects, school projects, Icy Phoenix, IntegraMOD, and a few other things. I'll try to get to if friday.

winzombie commented 7 years ago

oh sry dotn see that

vendethiel commented 7 years ago

I'm done. Just let me commit and it should be okay™.

I'll still test a few more things out.

You need to try it out tho. I only tested with 2 members.

vendethiel commented 7 years ago

Here. Should be all-good. As you can see, I pretty much rewrote the mods.

The two tiny things to do are listed in the first message of this issue. (I didn't try the forum thing. Not sure I even like it..)

vendethiel commented 7 years ago

@winzombie mind confirming if it works (or not)?

winzombie commented 7 years ago

oh, try it tomorrow, cuz working

vendethiel commented 7 years ago

I'm gonna leave it at that, because it should work correctly.