Fix for 204201+ - Githubissues

vendetta-mod / Vendetta

A mod for Discord's mobile apps.

BSD 3-Clause "New" or "Revised" License

1.46k stars 91 forks source link

Fix for 204201+ #185

Closed pylixonly closed 9 months ago

pylixonly commented 10 months ago

Discord made reload-less theme changing a reality
Vendetta (and its plugins) broke because it depended on the old one
Reimplemented createThemedStyleSheet to keep compatibility, but might have a few disadvantages (over the new one)
All Vendetta components now use the new system, however, since I could not figure out how they did it for class components, I was forced to turn some part of it into a function component so I could use hooks.

All additions are made into the metro/common.ts because I am lazy :3.

Aqqly commented 10 months ago

LGTM

pylixonly commented 10 months ago

Odd, it shows just fine for me

maisymoe commented 10 months ago

Hmm, I suppose they changed something then? Or I was just doing something wrong the other day? Well, if that's the case, LGTM!

pylixonly commented 10 months ago

Could be the first, I remember amoled was just being shown as dark way back then

maisymoe commented 10 months ago

I did just think of something else, actually. This will completely break on current stable builds, since they're still on 203. I suppose we could just wait until they get 204 but... hmm.

pylixonly commented 10 months ago

Right.. or (temporarily) revert changes to our components?

redstonekasi commented 9 months ago

I think that's the best choice really, it'll be a while before we can use the new system without breaking Vendetta for a significant amount of users.

maisymoe commented 9 months ago

I'll probably make all our stuff use the old system, then. Discord are taking longer than I wanted to publish this stable, and as Kasi mentions, there are people on much older versions of Discord.

maisymoe commented 9 months ago

With the backwards compat changes I ~~forced~~ asked Kasi to implement, this now reliably supports 204+ while maintaining compatibility with lower versions. Time for merge!