search

vendetta-mod / Vendetta

A mod for Discord's mobile apps.
BSD 3-Clause "New" or "Revised" License
1.46k stars 91 forks source link

bug(plugins - slash commands): displayName gets spam printed into the chatbox in certain conditions #198

Open Ushie opened 9 months ago

Ushie commented 9 months ago

Bug

In plugins, when a slash command option includes a space (presumably) it spams the content of the displayName into the value of the option

Image of the option's code
![image](https://github.com/vendetta-mod/Vendetta/assets/79272171/8d421ad5-d921-4fee-8052-14417fd9d143)
Recording of the bug
https://github.com/vendetta-mod/Vendetta/assets/79272171/d569f7fa-5db5-4c3f-a1cd-fd34fd222023

Expected behavior

When not including any spaces, this bug doesn't happen, which is the expected behavior for both cases

Image of the option's code
![image](https://github.com/vendetta-mod/Vendetta/assets/79272171/dc78056b-4284-4933-a847-a758a598938b)
Screenshot of behavior
![image](https://github.com/vendetta-mod/Vendetta/assets/79272171/0da6c174-650c-41ef-b947-423513bc88d4)

Extra info

Debug info
![image](https://github.com/vendetta-mod/Vendetta/assets/79272171/d8ed3c3e-08db-48a7-a63f-bac4b7941435)
Cynosphere commented 7 months ago

I personally don't see this as worth fixing as its behavior Discord never accounted for. Slash command names and option names are always lowercase with no spaces except for subcommands.

At most there could probably be protections in place to prevent this on our end.