search

vendetta-mod / Vendetta

A mod for Discord's mobile apps.
BSD 3-Clause "New" or "Revised" License
1.46k stars 91 forks source link

Lockfiles are in .gitignore #79

Open NotNite opened 1 year ago

NotNite commented 1 year ago

Lockfiles for npm, pnpm, & yarn are all ignored in this project (and in the plugin template?), meaning builds aren't technically reproducible as versions can drift. See Working with Git § Lockfiles in the pnpm documentation for why they're important.

maisymoe commented 1 year ago

Lockfiles for npm, pnpm, & yarn are all ignored in this project (and in the plugin template?), meaning builds aren't technically reproducible as versions can drift. See Working with Git § Lockfiles in the pnpm documentation for why they're important.

We were having issues with the CI as well as PRs when committing lockfiles early on in the project lifespan. Might be something I look into fixing in future though.