search

vendi-advertising / vendi-cache-2

0 stars 0 forks source link

I'd really like to simplify the file system caching rules #33

Open cjhaas opened 7 years ago

cjhaas commented 7 years ago

Do we really need to use the nested file system? I'm pretty the only reasons are perf and invalid characters.

I think a cache-miss is generally better than complex rules, especially because it won't happen too often. I think WP's default URL sanitization strategy does a good enough job for 99.9% of URLs, if not more.

As for perf, we'd need to test things but it seems that everyone else is fine with using the path for the FS part. Maybe thousands of URLs might be a problem but I'd like to see some real numbers

cjhaas commented 7 years ago

I'd really like to get this down to either a try_files in Nginx but these can't be chained so I think they still need a rewrite to cause the engine to jump and look for the new location. This makes including vendi-cache in Nginx much simpler.