Fixing a couple of issues reported by a client with Vendr Checkout translations.
As the master template prevents property model errors from being rendered (@Html.ValidationSummary(true)) the invalid discount code message just displayed an empty box - I have set the property to an empty string for this error message
Upon fixing the invalid discount code message we discovered it wasn't translatable via a dictionary value - I have added a VendrCheckout.Information.InvalidDiscountGiftCode dictionary key that can be used to override the default
The default values for the prev / next buttons did not include the step name - the {0} placeholder had been missed off the dictionary fallback value. I see this was recently fixed in d732121 for Vendr Checkout V2.
The step name in the prev / next buttons usually has a capital letter at the start, given as it is a node name. This looks a bit odd, e.g. "Continue to Shipping method", so I have .ToLower()'d step names for a more natural read.
I appreciate this PR is targeted to Vendr Checkout V1, simply because this is what affects our client. It should be easy to merge these changes up to Vendr Checkout V2 also!
Fixing a couple of issues reported by a client with Vendr Checkout translations.
As the master template prevents property model errors from being rendered (
@Html.ValidationSummary(true)) the invalid discount code message just displayed an empty box - I have set the property to an empty string for this error messageUpon fixing the invalid discount code message we discovered it wasn't translatable via a dictionary value - I have added a
VendrCheckout.Information.InvalidDiscountGiftCodedictionary key that can be used to override the defaultThe default values for the prev / next buttons did not include the step name - the
{0}placeholder had been missed off the dictionary fallback value. I see this was recently fixed in d732121 for Vendr Checkout V2.The step name in the prev / next buttons usually has a capital letter at the start, given as it is a node name. This looks a bit odd, e.g. "Continue to Shipping method", so I have
.ToLower()'d step names for a more natural read.I appreciate this PR is targeted to Vendr Checkout V1, simply because this is what affects our client. It should be easy to merge these changes up to Vendr Checkout V2 also!